[openib-general] rdma_cm.h: comment nits.

Sean Hefty mshefty at ichips.intel.com
Mon May 8 09:51:27 PDT 2006


Michael S. Tsirkin wrote:
> Two nits wrt rdma_cm.h:
> 
> /**
>  *  * rdma_reject - Called on the passive side to reject a connection request.
>  */
> 
> 
> Its OK to call rdma_reject on active side as well, isn't it?

Yes - but only for users that are managing the QP states themselves.

> /**
>  * rdma_cm_event_handler - Callback used to report user events.
>  *
>  * Notes: Users may not call rdma_destroy_id from this callback to destroy
>  *   the passed in id, or a corresponding listen id.  Returning a
>  *   non-zero value from the callback will destroy the corresponding id.
>  */
> 
> CMA will actually always destroy the passed in id, not the "corresponding id".

Correct - the passed in id is destroyed.

I will update the comments.

- Sean



More information about the general mailing list