[openib-general][patch review] srp: fmr implementation,

Roland Dreier rdreier at cisco.com
Mon May 8 11:35:09 PDT 2006


    Vu> This fmr patch does not work for ia64 system because this
    Vu> fmr_page_mask is defined as unsigned int.

Great catch!

    Vu> We should type cast it to u64 or define it as unsigned long

Casting it won't help because it will just get zero-extended.  I think
we need the following in ib_srp.h:

	unsigned long		fmr_page_mask;

and then in ib_srp.c:

	srp_dev->fmr_page_mask  = ~((unsigned long) srp_dev->fmr_page_size - 1);

does this work for you?

Thanks,
  Roland



More information about the general mailing list