[openib-general] Re: [PATCH 3/3] librdmacm: add ability to get/set transport specific options

[Michael S. Tsirkin]

Quoting r. Jack Morgenstein <jackm at mellanox.co.il>:
> Subject: Re: [PATCH 3/3] librdmacm: add ability to get/set transport specific options
> 
> On Tuesday 09 May 2006 19:25, Sean Hefty wrote:
> >
> > This is fine for route lookup, but not rdma_get_option.
> >
> I missed adding rdma_ib.c to my tag file, so missed the rdma_get_option usage 
> of local_sa.c -- sorry about that.
> 
> My preference is to take the most recent rdma_cm, since there are several 
> important bug fixes since svn 6860; also, we avoid the ABI issue.
> 
> Sounds like I should add a dummy "ib_local_sa.h" file to OFED kernel build, 
> with static-inlines for all functions exported by local_sa.c -- and have 
> these functions return -ENOSYS (as you suggested), and instead modify 
> cma_resolve_ib_route() as follows:
> 
> Index: cma.c
> ===================================================================
> --- cma.c       (revision 6980)
> +++ cma.c       (working copy)
> @@ -1172,7 +1172,7 @@ static int cma_resolve_ib_route(struct r
>                 route->num_paths = 1;
>                 queue_work(cma_wq, &work->work);
>         } else {
> -               if (ret == -ENODATA)
> +               if (ret == -ENODATA || ret == -ENOSYS)
>                         ret = cma_query_ib_route(id_priv, timeout_ms, work);
>                 if (ret)
>                         goto err2;
> 
> - Jack
> 
> P.S., 
> (maybe it would be a good idea to have this change in any event on the main 
> trunk, and not just for OFED?)

Maybe just return -ENODATA? Then you don't need to modify any code ...

-- 
MST