[openib-general] Re: [PATCH] IB/sdp: Fix warning on 32-bit architectures

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: [PATCH] IB/sdp: Fix warning on 32-bit architectures
> 
> The current definition of SDP_OP_RECV leads to:
> 
>     drivers/infiniband/ulp/sdp/sdp_bcopy.c:208: warning: integer constant is too large for "long" type
> 
> on 32-bit architectures.  Fix this by making it explicitly u64.
> 
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
> 
> --- infiniband/ulp/sdp/sdp.h	(revision 7012)
> +++ infiniband/ulp/sdp/sdp.h	(working copy)
> @@ -38,7 +38,7 @@ extern int sdp_debug_level;
>  
>  #define SDP_NUM_WC 4
>  
> -#define SDP_OP_RECV 0x800000000L
> +#define SDP_OP_RECV ((u64) 0x800000000LL)


Wouldnt 0x800000000LL be enough?

-- 
MST