[openib-general] [PATCH v3] ipoib: convert to use new multicast interface

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [openib-general] [PATCH v3] ipoib: convert to use new multicast interface
> 
>     Michael> I also think it might make sense to use the new SA query
>     Michael> retry support.  I think currently ipoib retries SA
>     Michael> queries by itself.
> 
> Yes, IPoIB does the retrying itself now.
> 
> So are you voting in favor of adding the SA retry stuff for 2.6.18?

Oh, I donnu. I find the idea itself appealing.  OTOH, I was assuming that SA
retry stuff would be a prerequisite for CMA - I thought that for CMA it makes
sens to use SA retry since it does not handle retries itself, but for some
reason it seems to pass 0 as retries parameter.

I was just pointing out that *if* the SA retry stuff goes in
then it makes sense to use it in IPoIB, since its quite easy.

> How about the separate multicast module?

I'm nervous about doing big changes in the multicast code in ipoib - it had more
than a fair share of subtle races.

I wander whether we can avoid this by simply preventing userspace from touching
IPoIB multicast groups. I have a gut feeling this might also be a good idea,
security wise.

What do you think?

-- 
MST