[openib-general] [resend][RFC][PATCH] adding call to madvise

Roland Dreier rdreier at cisco.com
Thu May 11 16:40:55 PDT 2006


    Gleb> I'll move this to memory.c. What about libmthca? Leave it in
    Gleb> the header there?

I guess so.

    Gleb> Yes. Absolutely. AFAIK you are going to remove libsysfs
    Gleb> dependency and break ABI with this change, I think we can
    Gleb> piggyback this one then.

Right, I should open a libibverbs 1.1 tree for ABI breaking changes soon.

    Gleb> libmthca uses __mthca_reg_mr() to do internal registrations
    Gleb> (qp, cq).  If every hw driver will set them we can remove
    Gleb> this from libibverbs.

But don't you the madvise by hand for these cases?

It's definitely better to have libibverbs set common fields of
non-HW-dependent data structures.  I guess I still don't follow why
these fields are set in two places.

 - R.



More information about the general mailing list