[openib-general] [PATCH] Replace cl_memory.h by string.h

Hal Rosenstock halr at voltaire.com
Wed May 17 15:44:11 PDT 2006


On Wed, 2006-05-17 at 18:20, Sasha Khapyorsky wrote:
> On 15:05 Wed 17 May     , Roland Dreier wrote:
> > Just curious -- what's the reason behind changes like:
> > 
> >  > --- a/osm/complib/cl_event_wheel.c
> >  > +++ b/osm/complib/cl_event_wheel.c
> >  > @@ -40,6 +40,7 @@ #  include <config.h>
> >  >  #endif /* HAVE_CONFIG_H */
> >  >  
> >  >  #include <math.h>
> >  > +#include <complib/cl_memory.h>
> >  >  #include <complib/cl_event_wheel.h>
> >  >  #include <complib/cl_debug.h>
> > 
> > It seems including cl_memory.h in more places is a step backwards, or
> > am I missing the point here?
> 
> It is necessary for explicit prototyping yet used cl_malloc(),
> cl_free(). I guess this will be removed with next wave of Hal's cleanup.

Yes, that's what I expect too. When cl_malloc*/cl_free get removed, this
will go away...

-- Hal

> Sasha




More information about the general mailing list