[openib-general] Re: [PATCH 35 of 53] ipath - some interrelated stability and cleanliness fixes

Dave Olson olson at unixfolk.com
Thu May 18 00:04:28 PDT 2006


On Wed, 17 May 2006, Roland Dreier wrote:
| I do see obvious bugs in ipath_user_pages.c, though.  In
| ipath_release_user_pages_on_close(), you have:
| 
| 		mm = get_task_mm(current);
| 		if (!mm)
| 			goto bail;

It turns out that since this is called from ipath_close(),
mm will always be NULL, so what we do is leak memory, and
possibly leave some locked pages.  I've been looking at this
code this evening; fixing it is clearly needed, but doesn't help
the long delays, hangs, and watchdogs, so far.

Dave Olson
olson at unixfolk.com
http://www.unixfolk.com/dave



More information about the general mailing list