[openib-general] Re: [PATCH 1/2] mthca support for max_map_per_fmr device attribute

Roland Dreier rdreier at cisco.com
Tue May 23 09:13:00 PDT 2006


    Or> Also, if the patch makes sense and the memfree issue is
    Or> resolved, i'd like to change the name of the device attribute
    Or> from max_map_per_fmr to max_remaps_per_fmr, i can resend this
    Or> patch series with this fix.

The patch makes sense, although of course you need to make sure you
understand and handle the mem-free case as well if you want it
applied.  I'm not sure changing to max_remaps_per_fmr is really
clearer, since the value counts the first mapping of the FMR (which is
not a remapping).  But I guess I could be convinced if more people
think it's clearer.

 - R.



More information about the general mailing list