[openib-general] [PATCH] IB/iser: removed redundant check from iser's conn_bind transport function

Or Gerlitz ogerlitz at voltaire.com
Tue May 30 04:59:54 PDT 2006


This fix isn't critical but it aligns the code to be as in the buddy
iscsi_tcp driver - Or.

removed redundant check of the conn stop_stage from iser's conn_bind transport func

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index c3eeeaa..4d14eb8 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -348,23 +348,21 @@ iscsi_iser_conn_bind(struct iscsi_cls_se
 	if (error)
 		return error;

-	if (conn->stop_stage != STOP_CONN_SUSPEND) {
-		/* the transport ep handle comes from user space so it must be
-		 * verified against the global ib connections list */
-		ib_conn = iscsi_iser_ib_conn_lookup(transport_eph);
-		if (!ib_conn) {
-			iser_err("can't bind eph %llx\n",
-				 (unsigned long long)transport_eph);
-			return -EINVAL;
-		}
-		/* binds the iSER connection retrieved from the previously
-		 * connected ep_handle to the iSCSI layer connection. exchanges
-		 * connection pointers */
-		iser_err("binding iscsi conn %p to iser_conn %p\n",conn,ib_conn);
-		iser_conn = conn->dd_data;
-		ib_conn->iser_conn = iser_conn;
-		iser_conn->ib_conn  = ib_conn;
+	/* the transport ep handle comes from user space so it must be
+	 * verified against the global ib connections list */
+	ib_conn = iscsi_iser_ib_conn_lookup(transport_eph);
+	if (!ib_conn) {
+		iser_err("can't bind eph %llx\n",
+			 (unsigned long long)transport_eph);
+		return -EINVAL;
 	}
+	/* binds the iSER connection retrieved from the previously
+	 * connected ep_handle to the iSCSI layer connection. exchanges
+	 * connection pointers */
+	iser_err("binding iscsi conn %p to iser_conn %p\n",conn,ib_conn);
+	iser_conn = conn->dd_data;
+	ib_conn->iser_conn = iser_conn;
+	iser_conn->ib_conn  = ib_conn;

 	return 0;
 }



More information about the general mailing list