[openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

Arnd Bergmann arnd at arndb.de
Mon Nov 6 13:35:28 PST 2006


On Monday 06 November 2006 22:26, Hoang-Nam Ngyuen wrote:
> -       rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +       rblock = (struct hipz_query_hca*)ehca_alloc_fw_ctrlblock();

>  
> -       rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +       rblock = (struct hipz_query_port*)ehca_alloc_fw_ctrlblock();

The point Heiko made in his comment is that with ehca_alloc_fw_ctrlblock
returning a void*, you can (and _should_) remove the casts to other
pointer types.

	Arnd <><




More information about the general mailing list