[openib-general] [PATCH 5/6] Use pci_find_ht_capability() in drivers/pci/quirks.c

ebiederm at xmission.com ebiederm at xmission.com
Mon Nov 13 07:46:54 PST 2006


Segher Boessenkool <segher at kernel.crashing.org> writes:

>> What if we didn't try to solve a problem we don't have ?
>
> Yes exactly.
>
>> Have we yet encountered an HT device with that sort of bogus  capability
>> list ?
>
> Nope.  So whatever fancy time-to-live scheme we come
> up with, we cannot even test it, and it performance
> no useful function.  Nuke it :-)

If we really need to we can put a loop detector in pci_find_capability
by looking ahead a little.  So we really should not even need to change
the API to do this.

So nuke it and if it is important have pci_find_capability bail if
there are loops in the capability chain.

Eric




More information about the general mailing list