[openib-general] Problem with using krping

Roland Dreier rdreier at cisco.com
Fri Nov 24 18:01:32 PST 2006


Actually maybe the best fix is

-#define ALIGN(x,a) (((x)+(a)-1UL)&~((a)-1UL))
+#define ALIGN(x,a) (((x)+(a)-1L)&~((a)-1L))

(as far as I can see the problem is that the 1UL makes things
unsigned, not that it's a long -- so when the mask gets promoted to
u64, it is not sign extented).

I'll send a patch to Linus and davem later tonight to see what they say.




More information about the general mailing list