[openib-general] [PATCH v2] IB_mthca HCA profile module parameters

Roland Dreier rdreier at cisco.com
Mon Nov 27 20:42:31 PST 2006


OK, getting better, but still not there:

 > +	if (mthca_is_memfree(mdev)) {
 > +		mthca_check_profile_and_warn(num_udav,default_profile.num_udav,
 > +							 MTHCA_DEFAULT_NUM_UDAV);
 > +		mthca_check_profile_and_warn(fmr_reserved_mtts,default_profile.fmr_reserved_mtts,
 > +							 MTHCA_DEFAULT_NUM_RESERVED_MTTS);

fmr_reserved_mtts is actually only used for NON-memfree HCAs.

Also, coding style is spaces after commas, so you should do

	foo(x, y, z);

instead of

	foo(x,y,z);

I think it will be easier if I just try to fix this patch up myself
instead of iterating like this...




More information about the general mailing list