[openib-general] [PATCH 1/10] Driver Main files - netdev functions and corresponding state maintenance

[Roland Dreier]

 > +#ifdef CONFIG_INFINIBAND_VNIC_STATS
 > +	extern cycles_t recv_ref;
 > +#endif				/* CONFIG_INFINIBAND_VNIC_STATS */

put this declaration in a header file somewhere, not inside a function
in a .c file.

Also is it really worth having CONFIG_INFINIBAND_VNIC_STATS?  Who
would use it?  Or would anyone turn it off?  All the #ifdefs make the
code much harder to read so I think you need to figure out a better
way to make it conditional if you really want it to be configurable.

 > +	/* TBD */

 > +	/* TBD */

Umm...

 > +static BOOLEAN vnic_npevent_register(struct vnic *vnic, struct netpath *netpath)

What do you gain from having this shouting "BOOLEAN" type?