[openib-general] [PATCH 4/13] osm: port to WinIB stack : osmtest/osmtest.c
eitan at mellanox.co.il
Tue Oct 3 12:05:40 PDT 2006
I see this was not committed.
Do you see a reason it should not?
Michael had a generic comment of why we do not check range of parsed
values which also relates to "safe casting".
But to completely fix these we will probably need a separate patch.
Eitan Zahavi wrote:
>Explicit cast required for the win compiler to handle this...
>Signed-off-by: Eitan Zahavi <eitan at mellanox.co.il>
>--- osmtest/osmtest.c (revision 9502)
>+++ osmtest/osmtest.c (working copy)
>@@ -3281,7 +3281,7 @@ osmtest_validate_path_data( IN osmtest_t
> /* Also, this doesn't detect fewer than the correct number of paths being returned */
>- if ( p_path->count >= ( 1 << lmc ) * ( 1 << lmc ) )
>+ if ( p_path->count >= (uint32_t)( 1 << (2*lmc)) )
> osm_log( &p_osmt->log, OSM_LOG_ERROR,
> "osmtest_validate_path_data: ERR 0052: "
>openib-general mailing list
>openib-general at openib.org
>To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
More information about the general