[openib-general] [RFC] [PATCH 2/7] ib_multicast 2.6.20: add ib_multicast module to track join requests from the same port
Michael S. Tsirkin
mst at mellanox.co.il
Wed Oct 11 09:17:18 PDT 2006
Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> > Finally, the patch in question also seems to introduce more cleanups and
> > such. It would be less controversial if it was just an API change.
> The cleanups are part of the change. Once ib_join_multicast() has been invoked,
> ib_free_multicast() must be called exactly once. Proper state tracking for this
> is required.
We already do state tracking to join/leave groups properly.
It would be easier to review this change if you left killing off
mcast->done and other such improvements for a separate patch.
More information about the general