[openib-general] [PATCH] osm: reviewing osmtest - osmt_multicast.c

[Hal Rosenstock]

On Tue, 2006-10-17 at 16:21, Yevgeny Kliteynik wrote:
> Hal Rosenstock wrote:
> > On Tue, 2006-10-17 at 12:07, Yevgeny Kliteynik wrote:
> >> Hi Hal
> >>
> >> Fixing more things in the multicast test flow.
> >>  
> >> Still have things to do in case when multicast group removal
> >> fails, and have to add some cleanup (as we've discussed previously).
> >> --
> >> Yevgeny
> >>
> >> Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> > 
> > Looks good. One question below.
> > 
> > -- Hal
> > 
> >> Index: osmtest/osmt_multicast.c
> >> ===================================================================
> >> --- osmtest/osmt_multicast.c	(revision 9856)
> >> +++ osmtest/osmt_multicast.c	(working copy)
> > 
> > [snip...]
> > 
> >> @@ -3261,6 +3306,7 @@ osmt_run_mcast_flow( IN osmtest_t * cons
> >>                                          &mc_req_rec,
> >>                                          comp_mask,
> >>                                          &res_sa_mad );
> >> +      status = IB_SUCCESS;
> > 
> > This doesn't look right to me.
> 
> Right, this must be some cut-and-paste bug.
> This line shouldn't be there. Good catch.
> Thanks.

Thanks. Applied with some cosmetic changes.

-- Hal

> --
> Yevgeny.
> 
> >>        if (status != IB_SUCCESS)
> >>        {
> >>          osm_log( &p_osmt->log, OSM_LOG_ERROR,
> >> @@ -3274,6 +3320,10 @@ osmt_run_mcast_flow( IN osmtest_t * cons
> >>          fail_to_delete_mcg++;
> >>        }
> >>      }
> >> +    else
> >> +    {
> >> +      end_ipoib_cnt++;
> >> +    }
> >>      p_mgrp = (osmtest_mgrp_t*)cl_qmap_next( &p_mgrp->map_item );
> >>    }
> >>  
> > 
> > [snip...]
> > 
> >