[openib-general] [PATCH] [cma] qp_access_flags was changed to zero

Dotan Barak dotanb at dev.mellanox.co.il
Tue Oct 24 05:00:29 PDT 2006


Sean Hefty wrote:
> Sean Hefty wrote:
>> I think there's a related issue in the ib_cm, which also sets 
>> IB_ACCESS_LOCAL_WRITE.  The above code is executed when the user 
>> calls rdma_create_qp().  The ib_cm routine is executed when 
>> connecting the QP, which will overwrite these settings.  I think 
>> we'll want to change both places to get the desired result.
>
> I've pulled in your patch, along with a similar patch to the ib_cm.  
> I'll run through some tests tomorrow to verify that nothing broke.  
> Unless this is causing a serious issue, though, I will request this 
> fix for 2.6.20.
>
> - Sean
Great, thanks.

There were two reasons for me to send this patch in the first place:
1) if the low level driver will add a check to the remote access 
permission, this code may fail.
2) the core is being used as a reference code for new programmers, so it 
should be correct.


thanks
Dotan




More information about the general mailing list