[openib-general] [PATCH] diags/saquery: fix node_desc.description as string usages

Michael S. Tsirkin mst at mellanox.co.il
Tue Oct 31 05:46:45 PST 2006


Quoting r. Sasha Khapyorsky <sashak at voltaire.com>:
> > > Look at this for example:
> > > http://sourceware.org/ml/bug-glibc/2005-02/msg00123.html
> > 
> > Hmm, yea. Do you understand the answer there?
> > Does not make sense to me ...
> 
> I less care about the answer, but more about valgrind output (btw
> cannot see this with glibc-2.5) and similar "corner case" issues.

Well, I understand what you are saying, but whether a work-around is worth it
depends on whether the issue is still relevant in distros in use today - the
message you quote is from 2005.  After all, you never know whether some other
piece of code triggers a compiler bug in some rare case on some outdated distro.

Can you run valgrind on the simple test and check?

In any case, I think we need a commment so we can clean this up
sometime in the future.

-- 
MST




More information about the general mailing list