[openib-general] [PATCH] cma_connect_ib leaks memory in failure cases.

Michael S. Tsirkin mst at mellanox.co.il
Mon Sep 11 10:53:12 PDT 2006


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH] cma_connect_ib leaks memory in failure cases.
> 
> Michael S. Tsirkin wrote:
> >>cma_connect_ib leaks an struct ib_cm_id* in failure cases.
> >>
> >>Signed-off-by: Krishna Kumar <krkumar2 at in.ibm.com>
> > 
> > 
> > This one looks like it might be good for 2.6.18. Sean?
> 
> The ib_cm_id will be cleaned up if the rdma_cm_id is destroyed, as long as a 
> second call is not made to rdma_connect after the first call fails.  So we're 
> probably safe deferring this until 2.6.19, unless someone has code which calls 
> rdma_connect twice.

SDP can do this I think.

-- 
MST




More information about the general mailing list