[openib-general] [PATCH] cma_connect_ib leaks memory in failure cases.

[Michael S. Tsirkin]

Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH] cma_connect_ib leaks memory in failure cases.
> 
> Michael S. Tsirkin wrote:
> >>The ib_cm_id will be cleaned up if the rdma_cm_id is destroyed, as long as a 
> >>second call is not made to rdma_connect after the first call fails.  So we're 
> >>probably safe deferring this until 2.6.19, unless someone has code which calls 
> >>rdma_connect twice.
> > 
> > SDP can do this I think.
> 
> To clarify, SDP would need to do something like:
> 
> ret = rdma_connect(id_7471 ...)
> if (ret)
> 	rdma_connect(id_7471 ...)
> 
> The same ID would need to be used twice.
> 
> - Sean
> 

Sure - if connect on socket fails, application can retry.

-- 
MST