[openib-general] Bug in OpenSM multicast group creation?

[Hal Rosenstock]

On Mon, 2006-09-18 at 18:34, Roland Dreier wrote:
> Around line 1340 of osm_sa_mcmember_record.c, there is the code:
> 
>   /* the mcmember_record should have mtu_sel, rate_sel and pkt_lifetime_sel = 2 */
>   (*pp_mgrp)->mcmember_rec.mtu |= 2<<6; /* exactly */
>   (*pp_mgrp)->mcmember_rec.rate |= 2<<6; /* exactly */
>   (*pp_mgrp)->mcmember_rec.pkt_life |= 2<<6; /* exactly */
> 
>   /* Initialize the mgrp */
>   (*pp_mgrp)->mcmember_rec = mcm_rec;
>   (*pp_mgrp)->mcmember_rec.mlid = mlid;
> 
> I don't know exactly what this is trying to do,

The response is required to have the selectors set to exactly regardless
of what they were in the request.

> but it looks very fishy to me:

Now that you point it out, me too :-(

>  as far as I can see, the second block of code overwrites
> the effects of the first three lines.  So either those "/* exactly */"
> lines aren't needed, or they need to be moved after the mgrp is
> initialized.

It appears to me that they should be moved after those 2 lines of mgrp
initialization.

-- Hal

>  - R.