[openib-general] [PATCH] IB/Kconfig: add help text and change CMA config name

Or Gerlitz ogerlitz at voltaire.com
Tue Sep 19 05:49:06 PDT 2006


Roland Dreier wrote:
>     Or> I want it to be visible so if some other config **depends** on
>     Or> it the use can **see** this config and select it.
> 
>     Or> Also as of the importance of the rdma cm within the IB stack
>     Or> being along with the ib verbs the second access point to ULP
>     Or> coders, seeing its config and documenting it is important.
> 
> I don't buy this.  The only thing making this config option visible
> does is make it more likely (far more likely) that someone will
> disable it.  Right now the RDMA CM is built as long as INFINIBAND and
> INET are enabled.  No one is going to turn off INET on any normal
> system so effectively the RDMA CM is always built whenever INFINIBAND
> is enabled.

I am fine with having the CMA config selected whenever someone selects 
INFINIBAND so adding the help text and making it visible are not a must 
per my taste. However, are you fine with changing the **name** of the 
config directive to CONFIG_INFINIBAND_RDMA_CM so its better understood?

> As far as making a config symbol to depend on, I think INET makes as
> much sense or more: something using IP addressing naturally depends on
> having IP networking.

As Erez wrote you on the other thread, we must depend on the CMA else a 
user running make rndconfig would be able to produce a config file where 
  INFINIBAND is selected but the CMA (RDMA_ADDR_TRANS) config is not 
selected so linkage will fail.

Or.





More information about the general mailing list