[openib-general] [PATCH] IB/ipoib: user appropriate mtu selector for path queries

[Michael S. Tsirkin]

Quoting r. Michael S. Tsirkin <mst at mellanox.co.il>:
> Subject: Re: [PATCH] IB/ipoib: user appropriate mtu selector for path queries
> 
> Quoting r. Roland Dreier <rdreier at cisco.com>:
> > Subject: Re: [PATCH] IB/ipoib: user appropriate mtu selector for path queries
> > 
> > I didn't really read the new patch before... anyway:
> > 
> > Why have you changed from the approach of just using the broadcast
> > group's MTU?  As far as I can see, the issue being addressed here is
> > purely theoretical anyway, but with the approach of taking the current
> > device MTU, you now have to flush all the paths if the configured MTU
> > changes, and you have to have a big switch in path_rec_start().
> > 
> >  - R.
> > 
> 
> I'm not sure priv->broadcast is always initialized when we start
> a path record query. Is there a reason why it is?

It also seemed kind of nice to be able to control the path MTU
from dev->mtu - and I don't think path flush on mtu change is an issue
from the performance POV.

What do you think?

-- 
MST