[openib-general] [PATCH] IB/Kconfig: add help text and change CMA config name

Or Gerlitz ogerlitz at voltaire.com
Wed Sep 20 02:23:22 PDT 2006


Roland Dreier wrote:
>     Or> I am fine with having the CMA config selected whenever someone
>     Or> selects INFINIBAND so adding the help text and making it
>     Or> visible are not a must per my taste. However, are you fine
>     Or> with changing the **name** of the config directive to
>     Or> CONFIG_INFINIBAND_RDMA_CM so its better understood?
> 
> No, since really what it is controlling is the ib_addr module.

Just for the record it is controlling the build of both ib_addr and 
rdma_cm modules where rdma address resolution is a part from the overall 
rdma communication management managed by the rdma_cm module.

Anyway, if you prefer to leave the config name as is, let it be.

>     Or> As Erez wrote you on the other thread, we must depend on the
>     Or> CMA else a user running make rndconfig would be able to
>     Or> produce a config file where INFINIBAND is selected but the CMA
>     Or> (RDMA_ADDR_TRANS) config is not selected so linkage will fail.
> 
> How?  make randconfig won't produce invalid configurations.

I think i got it (at last) if INFINIBAND is selected it causes the 
selection of INFINIBAND_ADDR_TRANS as long as INET is selected so if 
something (eg iSER) is dependent on INFINIBAND and INET make rndconfig 
would do the job of selecting both of them when it selects iSER, correct?

Or.






More information about the general mailing list