[openib-general] [PATCH] IB/ipoib: user appropriate mtu selector for path queries

Michael S. Tsirkin mst at mellanox.co.il
Wed Sep 20 21:57:13 PDT 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] IB/ipoib: user appropriate mtu selector for path queries
> 
>     Michael> I'm not sure priv->broadcast is always initialized when
>     Michael> we start a path record query. Is there a reason why it is?
> 
> IPoIB can't send a packet until the broadcast group is joined, since
> it doesn't do netif_carrier_on() until then.  So I don't see any way
> that a path record query could start before we know the real mtu.

Good point, thanks. If we switch to that, a BUG_ON(priv->broadcast) just in case
won't hurt tough, would it?

-- 
MST




More information about the general mailing list