[ofa-general] [PATCH] osm: fixing log messages in case of uncompatible MTU/RATE

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Tue Apr 17 07:12:55 PDT 2007


Hi Hal,

Log messages that state that required mcast group
RATE/MTU doesn't match the RATE/MTU the request are
misleading.
Feel free to change the exact words of the log messages,
but the previous messages got me confused when I was
debugging mcast join failures.

It's not really a bug, so please apply to master only.

Thanks.

Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
---
 osm/opensm/osm_sa_mcmember_record.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/osm/opensm/osm_sa_mcmember_record.c b/osm/opensm/osm_sa_mcmember_record.c
index 91db3ad..50c4f22 100644
--- a/osm/opensm/osm_sa_mcmember_record.c
+++ b/osm/opensm/osm_sa_mcmember_record.c
@@ -619,7 +619,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested MTU %x is not greater than %x\n",
+                 "Requested mcast group has MTU %x, which is not greater than %x\n",
                  mtu_mgrp, mtu_required );
         return FALSE;
       }
@@ -629,7 +629,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested MTU %x is not less than %x\n",
+                 "Requested mcast group has MTU %x, which is not less than %x\n",
                  mtu_mgrp, mtu_required );
         return FALSE;
       }
@@ -639,7 +639,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested MTU %x is not equal to %x\n",
+                 "Requested mcast group has MTU %x, which is not equal to %x\n",
                  mtu_mgrp, mtu_required );
         return FALSE;
       }
@@ -663,7 +663,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested RATE %x is not greater than %x\n",
+                 "Requested mcast group has RATE %x, which is not greater than %x\n",
                  rate_mgrp, rate_required );
         return FALSE;
       }
@@ -673,7 +673,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested RATE %x is not less than %x\n",
+                 "Requested mcast group has RATE %x, which is not less than %x\n",
                  rate_mgrp, rate_required );
         return FALSE;
       }
@@ -683,7 +683,7 @@ __validate_more_comp_fields(
       {
         osm_log( p_log, OSM_LOG_DEBUG,
                  "__validate_more_comp_fields: "
-                 "Requested RATE %x is not equal to %x\n",
+                 "Requested mcast group has RATE %x, which is not equal to %x\n",
                  rate_mgrp, rate_required );
         return FALSE;
       }
-- 
1.4.4.1.GIT





More information about the general mailing list