[ofa-general] Re: [PATCH] IPoIB/cm: Convert spin_lock_irqsave() to spin_lock_irq()

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: [PATCH] IPoIB/cm: Convert spin_lock_irqsave() to spin_lock_irq()
> 
> There are quite a few places in ipoib_cm.c where we know IRQs are
> enabled because we do something that sleeps in the same function, so
> we can convert several occurrences of spin_lock_irqsave() to a plain
> spin_lock_irq().  This cleans up the source a little and makes the
> code smaller too:
> 
> add/remove: 0/0 grow/shrink: 1/5 up/down: 3/-51 (-48)
> function                                     old     new   delta
> ipoib_cm_tx_reap                             403     406      +3
> ipoib_cm_stale_task                          146     145      -1
> ipoib_cm_dev_stop                            173     172      -1
> ipoib_cm_tx_handler                          964     956      -8
> ipoib_cm_rx_handler                          956     937     -19
> ipoib_cm_skb_reap                            212     190     -22
> 
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
 
Makes sense to me.
Acked-by: Michael S. Tsirkin <mst at dev.mellanox.co.il>


-- 
MST