[ofa-general] Re: [PATCH] net/mlx4: modify sw reset

Michael S. Tsirkin mst at dev.mellanox.co.il
Wed Apr 25 13:31:18 PDT 2007


> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] net/mlx4: modify sw reset
> 
> Thanks, I applied a version of this that checks the vendor field is !=
> 0xffff instead of checking it against the mellanox value, because
> someone may build HCAs with a different vendor value.
> 
> Also is it worth taking the semaphore in the mthca reset function?

Why not? PRM says we should - the point of this is protecting against someone
accidentally touching flash while device is reset,
which will result is hangs, system errors or even data corruption.

-- 
MST



More information about the general mailing list