[ofa-general] [PATCH 2/4] ib/sa: add new QoS fields to path record
sean.hefty at intel.com
Mon Aug 6 22:07:53 PDT 2007
> > +#define IB_SA_PATH_REC_SERVICE_ID IB_SA_COMP_MASK( 0) \
> > + IB_SA_COMP_MASK( 1)
>I don't see anything using IB_SA_PATH_REC_SERVICE_ID in your patches,
>and as far as I can tell if there were something it wouldn't compile
>with this definition. Am I misreading how this macro would expand, or
>should it really be something like this?
>+#define IB_SA_PATH_REC_SERVICE_ID (IB_SA_COMP_MASK( 0) |\
>+ IB_SA_COMP_MASK( 1))
Your fix looks correct. Nothing yet is using the PR service ID fields. I
included it (poorly) for completeness, but it may have use for SRP or iSER. I'm
not sure on the changes for those.
More information about the general