[ofa-general] Re: [PATCH] libibverbs: Initialize reserved attributes in modify QP command

Dotan Barak dotanb at dev.mellanox.co.il
Wed Aug 8 23:02:30 PDT 2007


Roland Dreier wrote:
> We already include the header and use VALGRIND_MAKE_MEM_DEFINED in
> many places in libibverbs.  However in this case I think we really
> should be zeroing out reserved fields in the data we pass to the kernel.
>
>   
I have some more valgrind fixes:
    in some of them i initialize the reserved attribute
    in the others, i use VALGRIND_MAKE_MEM_DEFINED in a buffer which was 
filled by the kernel.

Roland: do you prefer that every fix will be posted in a separate patch 
(with the warning it fixes) or one patch for
all of the fixes i have?

thanks
Dotan



More information about the general mailing list