[ofa-general] ib_umem_get lock_limiting...

Roland Dreier rdreier at cisco.com
Thu Aug 16 13:33:04 PDT 2007


 > the calculation looks ok, but it looks to me like
 > the && should be an || in the test, esp since earlier
 > in the routine, we do an:
 > 
 >         if (!can_do_mlock())
 >                 return ERR_PTR(-EPERM);
 > 
 > so, maybe the !capable(CAP_IPC_LOCK) should not be
 > there at all?

No, I think the code is correct.  CAP_IPC_LOCK basically means we are
root and should ignore resource limits.  You can compare against the
code in sys_mlock() to see that it has exactly the same logic.



More information about the general mailing list