[ofa-general] [PATCH 0/7] osm: QoS in OpenSM

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Mon Aug 27 16:08:46 PDT 2007


Hi Sasha,

I'm sending the fixed patches, marked as V3.
Patch 1/7 has been already applied, so I'm sending
patches 2 to 7.

Main changes are:
  - Implemented binary search in range arrays instead of linear search
  - Global qos_policy was moved to osm_subn_t and updated he parser
    accordingly
  - Policy file is read from osm_subn_rescan_conf_files() in osm_subnet.c
    instead of osm_qos.c
  - Removing generated files by "make maintainer-clean"

-- Yevgeny

Yevgeny Kliteynik wrote:
> Hi Sasha
> 
> The following series of 7 patches adds new QoS fields
> to PathRecord and implements QoS policy file parser:
> 
> [1/7] Adding QoS fields to PathRecord
> [2/7] QoS policy file parser - Lex & Yacc files
> [3/7] QoS policy data structures and functions
> [4/7] Renaming static find_prtn_by_name() to non-static
>       osm_prtn_find_by_name() - it is used by QoS policy 
>       functions.
> [5/7] Compiling policy file parser.
>       C & H files are generated from Lex & Yacc files and
>       the generated files are compiled.
>       Generated files are not included in git, but they do
>       get included in RPM as they are also created by 
>       'make dist'.
> [6/7] Adding QoS policy file option to OpenSM:
>       -Y or --qos_policy_file
> [7/7] Reading QoS policy file
> 
> Most of the code is rather technical, w/o much logic to 
> review and discuss.
> 
> Right now I'm doing a fine-tuning of the patch that implements
> the actual PathRecord selection according to the matching QoS
> level, but I prefer to send this patch separately because IMO
> it deserves more thorough review.
> 
> -- Yevgeny
>  
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 




More information about the general mailing list