[ofa-general] [PATCH] Remove verbose debug from ib_echa

[Anton Blanchard]

Hi,

While debugging an ib_ehca issue I ended up with raw hcalls in dmesg:

PU0003 EHCA_ERR:ehca_plpar_hcall9 opcode=168 ret=ffffffffffffffd3 arg1=103d001403000002 arg2=203d0000000000a1 arg3=8a40000000000000 arg4=5a5b4c000 arg5=0 arg6=0 arg7=0 arg8=0 arg9=0 out1=0 out2=0 out3=0 out4=2 out5=0 out6=800000000005f254 out7=0 out8=0 out9=0

This simply serves to confuse the user, they wont know that the above
error really means "link down".

Signed-off-by: Anton Blanchard <anton at samba.org>
---

diff --git a/drivers/infiniband/hw/ehca/hcp_if.c b/drivers/infiniband/hw/ehca/hcp_if.c
index fdbfebe..2dd98c7 100644
--- a/drivers/infiniband/hw/ehca/hcp_if.c
+++ b/drivers/infiniband/hw/ehca/hcp_if.c
@@ -132,14 +132,6 @@ static long ehca_plpar_hcall_norets(unsigned long opcode,
 			continue;
 		}
 
-		if (ret < H_SUCCESS)
-			ehca_gen_err("opcode=%lx ret=%lx"
-				     " arg1=%lx arg2=%lx arg3=%lx arg4=%lx"
-				     " arg5=%lx arg6=%lx arg7=%lx ",
-				     opcode, ret,
-				     arg1, arg2, arg3, arg4, arg5,
-				     arg6, arg7);
-
 		ehca_gen_dbg("opcode=%lx ret=%lx", opcode, ret);
 		return ret;
 
@@ -188,21 +180,6 @@ static long ehca_plpar_hcall9(unsigned long opcode,
 			continue;
 		}
 
-		if (ret < H_SUCCESS)
-			ehca_gen_err("opcode=%lx ret=%lx"
-				     " arg1=%lx arg2=%lx arg3=%lx arg4=%lx"
-				     " arg5=%lx arg6=%lx arg7=%lx arg8=%lx"
-				     " arg9=%lx"
-				     " out1=%lx out2=%lx out3=%lx out4=%lx"
-				     " out5=%lx out6=%lx out7=%lx out8=%lx"
-				     " out9=%lx",
-				     opcode, ret,
-				     arg1, arg2, arg3, arg4, arg5,
-				     arg6, arg7, arg8, arg9,
-				     outs[0], outs[1], outs[2], outs[3],
-				     outs[4], outs[5], outs[6], outs[7],
-				     outs[8]);
-
 		ehca_gen_dbg("opcode=%lx ret=%lx out1=%lx out2=%lx out3=%lx "
 			     "out4=%lx out5=%lx out6=%lx out7=%lx out8=%lx "
 			     "out9=%lx",