[ofa-general] [PATCH 2/3] OpenSM: Fix incorrect reporting of routing engine/algorithm used

Al Chu chu11 at llnl.gov
Fri Dec 7 16:55:42 PST 2007


Hey Sasha,

I noticed that when a routing algorithm failed and defaulted back to
'minhop', the logs and the console did not report this change.  This is
because most of that code outputs the routing algorithm name that was
stored during configuration/setup.  The name isn't adjusted depending on
the routing algorithm's success/failure.

There are several ways this could be fixed.  I decided to easiest was to
stick a new routed_name field + lock into struct osm_routing_engine, and
set/use this new field respectively.

Note that within osm_ucast_mgr_process(), there is a slight logic change
from what was there before.  If the routing engine's call to
build_lid_matrices() failed, I've changed the logic to not call the
routing engine's ucast_build_fwd_tables() function.  This felt like the
correct logic and seems to be fine given all the routing algorithms in
OpenSM.  PLMK if there is some behavior subtlety I missed.

Thanks,
Al
-- 
Albert Chu
chu11 at llnl.gov
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-incorrect-reporting-of-routing-engine.patch
Type: text/x-patch
Size: 5519 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20071207/e1547bbc/attachment.bin>


More information about the general mailing list