[ofa-general] Re: [PATCH] OpenSM: Fix error return corner case

[Sasha Khapyorsky]

On 16:39 Mon 10 Dec     , Al Chu wrote:
> Hey Sasha,
> 
> I noticed that in osm_ucast_updn_setup(), the code has set the
> context/callbacks in the routing engine struct, but does not revert the
> changes if the later call to updn_init() fails.  The callbacks would be
> left in place and erroneously executed at a later time.  Patch is
> attached.
> 
> Thanks,
> Al
> 
> -- 
> Albert Chu
> chu11 at llnl.gov
> 925-422-5311
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory

> From caeb46ed713df285785d84930b1db1850e11d19b Mon Sep 17 00:00:00 2001
> From: Albert L. Chu <chu11 at llnl.gov>
> Date: Mon, 10 Dec 2007 16:27:07 -0800
> Subject: [PATCH] fix error return corner case
> 
> 
> Signed-off-by: Albert L. Chu <chu11 at llnl.gov>

Applied. Thanks.

(BTW please use tab character for indention. You can format you code
with opensm/osm_indent script if you wish.)

Sasha