[ofa-general] Re: [PATCH 2/3] OpenSM: Fix incorrect reporting of routing engine used

Sasha Khapyorsky sashak at voltaire.com
Sat Dec 22 05:28:40 PST 2007


On 16:41 Tue 18 Dec     , Al Chu wrote:
> Hey Sasha,
> 
> This patch 2/3 fixes the incorrect reporting of what routing engine was
> used in the logs and in the console.  Based on which routing engine
> succeeded in osm_ucast_mgr_process(), the result is stored in the
> 'routing_engine_used' and that result is used for the eventual output.
> The lock in print_status() is across all p_osm data now and now uses
> p_osm->lock.  The logic has been reverted in osm_ucast_mgr_process().
> 
> Some "special case" handling had to be done in osm_ucast_mgr_process()
> to determine if a routing engine suceeded or failed.  It's not pretty.
> I figure when routing engine chains are supported later on some re-org
> in the routing engine code will have to be done, so this could be fixed
> more properly at that time.
> 
> Thanks,
> Al
> 
> -- 
> Albert Chu
> chu11 at llnl.gov
> 925-422-5311
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory

> From 84571863cfe2ca2f427ee900b83c109afaca1897 Mon Sep 17 00:00:00 2001
> From: Albert L. Chu <chu11 at llnl.gov>
> Date: Tue, 18 Dec 2007 10:47:47 -0800
> Subject: [PATCH] fix incorrect reporting of routing engine
> 
> 
> Signed-off-by: Albert L. Chu <chu11 at llnl.gov>

Applied. Thanks.

Sasha



More information about the general mailing list