[openib-general] [RFC] [PATCH] ib_usa: export multicast and informinfo registration to userspace

Michael S. Tsirkin mst at mellanox.co.il
Sun Feb 4 06:00:19 PST 2007


+static void usa_remove_one(struct ib_device *device)
+{
+	struct usa_device *dev;
+
+	dev = ib_get_client_data(device, &usa_client);
+	if (!dev)
+		return;
+
+	mutex_lock(&usa_mutex);
+	list_del(&dev->list);
+	mutex_unlock(&usa_mutex);
+
+	/* TODO: force immediate device removal */
+	put_dev(dev);
+	wait_for_completion(&dev->comp);
+	kfree(dev);
+}

I think we really need to address this TODO.
An application waiting for data from SA needs to get woken up and get
an error code indicating that the device was removed.

This is currently broken in umad, but let's do it correctly here.

-- 
MST




More information about the general mailing list