[openib-general] openib diags installation issue

[Vladimir Sokolovsky]

Hi Hal,
I have the following issue while executing 'make DESTDIR=/var/tmp/OFED install':
See the patch below for fixing this issue.


 /usr/bin/install -c -m 644 './man/ibprintca.8' '/var/tmp/OFED/usr/local/ofed/share/man/man8/ibprintca.8'
 /usr/bin/install -c -m 644 './man/ibfindnodesusing.8' '/var/tmp/OFED/usr/local/ofed/share/man/man8/ibfindnodesusing.8'
make  install-data-hook
make[3]: Entering directory `/var/tmp/OFEDRPM/BUILD/ofa_user-1.2/src/userspace/management/diags'
for script in scripts/ibqueryerrors.pl scripts/ibswportwatch.pl scripts/iblinkinfo.pl scripts/ibprintswitch.pl scripts/ibprintca.pl scripts/ibfindnodesusing.pl; do \
                binname=`echo $script | sed -e "s/scripts\/\(.*\)/\1/"`; \
                cat $script | sed -e "s,use lib \"<prefix>\(/lib/perl\)\";,use lib \"/usr/local/ofed\1\";," > /usr/local/ofed/bin/$binname; \
                chmod 755 /usr/local/ofed/bin/$binname; \
        done
/bin/bash: line 2: /usr/local/ofed/bin/ibqueryerrors.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/ibqueryerrors.pl': No such file or directory
/bin/bash: line 2: /usr/local/ofed/bin/ibswportwatch.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/ibswportwatch.pl': No such file or directory
/bin/bash: line 2: /usr/local/ofed/bin/iblinkinfo.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/iblinkinfo.pl': No such file or directory
/bin/bash: line 2: /usr/local/ofed/bin/ibprintswitch.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/ibprintswitch.pl': No such file or directory
/bin/bash: line 2: /usr/local/ofed/bin/ibprintca.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/ibprintca.pl': No such file or directory
/bin/bash: line 2: /usr/local/ofed/bin/ibfindnodesusing.pl: No such file or directory
chmod: cannot access `/usr/local/ofed/bin/ibfindnodesusing.pl': No such file or directory
make[3]: *** [install-data-hook] Error 1
make[3]: Leaving directory `/var/tmp/OFEDRPM/BUILD/ofa_user-1.2/src/userspace/management/diags'
make[2]: *** [install-data-am] Error 2
make[2]: Leaving directory `/var/tmp/OFEDRPM/BUILD/ofa_user-1.2/src/userspace/management/diags'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/var/tmp/OFEDRPM/BUILD/ofa_user-1.2/src/userspace/management/diags'
make: *** [install_diags] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.37589 (%install)


Patch for fixing the issue above:

diff --git a/diags/Makefile.am b/diags/Makefile.am
index 06b21fc..81ece28 100644
--- a/diags/Makefile.am
+++ b/diags/Makefile.am
@@ -150,9 +150,9 @@ dist-hook: diags.spec
 install-data-hook:
        for script in $(IB_SW_COUNT_DEPENDANT); do \
                binname=`echo $$script | sed -e "s/scripts\/\(.*\)/\1/"`; \
-               cat $$script | sed -e "s,use lib \"<prefix>\(/lib/perl\)\";,use lib \"$(prefix)\1\";," > $(bindir)/$$binname; \
-               chmod 755 $(bindir)/$$binname; \
+               cat $$script | sed -e "s,use lib \"<prefix>\(/lib/perl\)\";,use lib \"$(prefix)\1\";," > $(DESTDIR)$(bindir)/$$binname; \
+               chmod 755 $(DESTDIR)$(bindir)/$$binname; \
        done
-       $(top_srcdir)/config/install-sh -m 755 -d $(prefix)/lib/perl
-       $(top_srcdir)/config/install-sh -m 755 scripts/IBswcountlimits.pm $(prefix)/lib/perl
+       $(top_srcdir)/config/install-sh -m 755 -d $(DESTDIR)$(prefix)/lib/perl
+       $(top_srcdir)/config/install-sh -m 755 scripts/IBswcountlimits.pm $(DESTDIR)$(prefix)/lib/perl