[openib-general] [PATCH] RDMA/iwcm: Bugs in cm_conn_req_handler()

Michael S. Tsirkin mst at mellanox.co.il
Wed Feb 7 04:35:34 PST 2007


-		set_bit(IWCM_F_CALLBACK_DESTROY, &cm_id_priv->flags);
-		destroy_cm_id(cm_id);
-		if (atomic_read(&cm_id_priv->refcount)==0)
-			kfree(cm_id);
+		BUG_ON(atomic_read(&cm_id_priv->refcount) != 1);
+		iw_cm_reject(cm_id, NULL, 0);
+		iw_destroy_cm_id(cm_id);

And BTW, lots of lines with atomic_read()==0 in them have broken whitespace
in iwcm.c. Does anyone care enough to fix them?

-- 
MST




More information about the general mailing list