[openib-general] [PATCH 3 of 4] IB/mthca: fix non-cache-coherent CPUs with memfree

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH 3 of 4] IB/mthca: fix non-cache-coherent CPUs with memfree
> 
> Queued for 2.6.21, although I think a further cleanup would be:
> 
>  >  	mdev->mr_table.mpt_table = mthca_alloc_icm_table(mdev, init_hca->mpt_base,
>  >  							 dev_lim->mpt_entry_sz,
>  >  							 mdev->limits.num_mpts,
>  > -							 mdev->limits.reserved_mrws, 1);
>  > +							 mdev->limits.reserved_mrws,
>  > +							 1, 1);
> 
> instead of having use_lowmem and use_coherent be separate parameters,
> we should probably convert it to a type parameter, and have
> MTHCA_ICM_TABLE_HIGHMEM, _LOWMEM and _COHERENT.  That would make these
> calls a lot easier to read and get correct.

Good idea.

-- 
MST