[openib-general] [PATCH] osm_vendor_ibumad: termination crash fix

Hal Rosenstock halr at voltaire.com
Tue Feb 20 06:43:01 PST 2007


On Mon, 2007-02-19 at 16:46, Sasha Khapyorsky wrote:
> When OpenSM is terminated umad_receiver thread still running even after
> the structures are destroyed and freed, this causes to random (but easily
> reproducible) crashes. The reason is that osm_vendor_delete() does not
> care about thread termination. This patch adds the receiver thread
> cancellation (by using pthread_cancel() and pthread_join()) and cares to
> keep have all mutexes unlocked upon termination. There is also minor
> termination code consolidation - osm_vendor_port_close() function.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

Good find.

Thanks! Applied (to both master and ofed_1_2).

-- Hal





More information about the general mailing list