[openib-general] [PATCHv2] IB/ipoib: Fix ipoib handling for pkey reordering

[Moni Levy]

On 2/27/07, Roland Dreier <rdreier at cisco.com> wrote:
>  > > I haven't really read it except to think "why is this so complicated"?
>  >
>  > Do you refer to that complication of the patch of the issue ?
>
> the patch.

Please advise and I'll change it.

>
>  > > Changing the P_Key index is not allowed for RTS->RTS.  You would have
>  > > to modify the QP RTS->SQD, wait for the SQ to drain, then modify the
>  > > P_Key index with SQD->SQD, and finally go SQD->RTS.
>  >
>  > Do you think that using that way to solve it will be a significant
>  > simplification ? We'll still have to reuse that handling for missed
>  > completion that is currently implemented in ipoib_ib_dev_stop and
>  > still have additional work element.
>
> no, I don't think SQD is really useful in practice.
>