[openib-general] [PATCH] for OFED 1.2

[Steve Wise]

On Tue, 2007-02-27 at 18:55 +0200, Michael S. Tsirkin wrote:
> > Quoting Sean Hefty <sean.hefty at intel.com>:
> > Subject: Re: [PATCH] for OFED 1.2
> > 
> > >Please send patches that will be added to kernel_patches/fixes.
> > >
> > >Please update your git tree from
> > >git://git.openfabrics.org/~vlad/ofed_1_2/.git  ofed_1_2
> > 
> > You want me to create a patch that adds a file that contains the actual patches?
> > 
> > Why not apply the patches directly?
> 
> That's the ofed structure, this was discussed multiple times already.
> The point is to keep all changes to upstream components separate,
> to make updating to upstream kernel trivial in the future.
> 
> Worked quite well for OFED 1.1 -> 1.2 transition.
> 

Having these patches as files is painful for every developer because
they cannot create a patch against ofed_1_2/drivers/infiniband/* nor the
kernel.org upstream tree.  They need to apply all the current patches
and then create a patch on top of that. Or hope the patch applies
fuzzily.  

I think with stacked git or just git and rebasing at key times, you
could keep an ofed_1_2 tree that folks can easily apply patches to...

Its too late to change this for 1.2, but you might want to reconsider
the design for 1.3.


my 2 cents...