[openib-general] [PATCH] for OFED 1.2

[Michael S. Tsirkin]

> Quoting Steve Wise <swise at opengridcomputing.com>:
> Subject: Re: [PATCH] for OFED 1.2
> 
> > > > 
> > > > Sean, please install quilt and try using it for working with the system.
> > > > Adding new patch is usually done in this way
> > > > quilt new <patch>
> > > > quilt add <files>
> > > > edit
> > > > quilt refresh
> > > > 
> > > > cp patches/<patch> kernel_patches/fixes/
> > > > git add kernel_patches/fixes/<patch>
> > > > git commit kernel_patches/fixes/<patch>
> > > 
> > > NOTE: The key to the above process is the assumption that the developer
> > > maintains _all_ of the existing patches from kernel_patches/ on top of
> > > the ofed_1_2 tree using quilt or stg.  Otherwise quilt/stg isn't buying
> > > you anything.
> > 
> > OFED will do this automatically.
> > 
> 
> uh, can you explain this?  Given I have a freshly cloned ofed_1_2 git
> tree, and I want to change cma.c (a good one cuz there are patches).
> What do I do?  There's no quilt stack at all at this point.  Right?  

Try running the configure script.
After this, quilt applied will show what patches are applied.

> > > And this doesn't take into account backports.
> > 
> > The process works with backport patches too: you just have to do this
> > 
> > > quilt pop -a
> > > 
> > > > > quilt new <patch>
> > > > > quilt add <files>
> > > > > edit
> > > > > quilt refresh
> > > 
> > > quilt push -a
> 
> 
> But you cannot keep a stack for more than one backport pushed, right?
> So you still need to be slapping the stacks of patches around for each
> backport.  
> 
> Or maybe I'm confused?

Yes.

Fortunately it's not too hard: you can do
quilt pop -a
and re-run configure for another kernel.

Of course for testing the patch, it is easier to commit the change in your tree
and then to use openfabrics cross-build functionality that will clone this
tree and build for multiple arches/kernels.


-- 
MST