[openib-general] [PATCH 1/4] osm: TRIVIAL - making comparison functions static (fat-tree routing)

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Tue Jan 2 08:18:36 PST 2007


Sasha Khapyorsky wrote:
> Hi Yevgeny,
> 
> On 15:30 Mon 01 Jan     , Yevgeny Kliteynik wrote:
>> Making two comparison functions in ftree static.
> 
> Good.
> 
> Any news about OSM_CDECL/__cdecl emilination?

Here's what I know by now:
__cdecl is default on windows, but osm is compiled with a flag
that makes __stdcall default (there are some problems linking
osm to other libraries without this flag), so OSM_CDECL is gonna 
stay. One thing I do need to check is removing the __stdcall 
and trying to recompile everything to see if the __stdcall
is still needed. 

-- Yevgeny.
 
> Sasha
> 
>> --
>> Yevgeny
>>
>> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
>> ---
>>  osm/opensm/osm_ucast_ftree.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/osm/opensm/osm_ucast_ftree.c b/osm/opensm/osm_ucast_ftree.c
>> index 0473135..32d1b3b 100644
>> --- a/osm/opensm/osm_ucast_ftree.c
>> +++ b/osm/opensm/osm_ucast_ftree.c
>> @@ -226,7 +226,7 @@ typedef struct ftree_fabric_t_
>>   **
>>   ***************************************************/
>>  
>> -int OSM_CDECL
>> +static int OSM_CDECL
>>  __osm_ftree_compare_switches_by_index(
>>     IN  const void * p1, 
>>     IN  const void * p2)
>> @@ -247,7 +247,7 @@ __osm_ftree_compare_switches_by_index(
>>  
>>  /***************************************************/
>>  
>> -int OSM_CDECL
>> +static int OSM_CDECL
>>  __osm_ftree_compare_port_groups_by_remote_switch_index(
>>     IN  const void * p1, 
>>     IN  const void * p2)
>> -- 
>> 1.4.4.1.GIT
>>
>>
>>
>> _______________________________________________
>> openib-general mailing list
>> openib-general at openib.org
>> http://openib.org/mailman/listinfo/openib-general
>>
>> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>>
> 




More information about the general mailing list