[openib-general] ib_gid_is_link_local

[Hal Rosenstock]

On Tue, 2007-01-02 at 10:25, Hal Rosenstock wrote:
> Hi Eitan,
> 
> I started to look at changes for IB routers and the following in
> ib_types.h doesn't look quite right to me:
> 
> static inline boolean_t OSM_API
> ib_gid_is_link_local(
>         IN      const   ib_gid_t* const         p_gid )
> {
>         return( ib_gid_get_subnet_prefix( p_gid ) == IB_DEFAULT_SUBNET_PREFIX );
> }
> 
> Shouldn't it be either the default subnet prefix or the one supplied in
> PortInfo:GidPrefix (which might not be the default one) ?

I propose changing the routine name to ib_gid_is_default_prefix so as
not to be misleading. Comments ? Patch to follow for this.

-- Hal

> -- Hal
> 
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>