[openib-general] [PATCH 1/10] cxgb3 - main header files

Caitlin Bestler caitlinb at broadcom.com
Tue Jan 9 10:29:12 PST 2007


 

> -----Original Message-----
> From: openib-general-bounces at openib.org 
> [mailto:openib-general-bounces at openib.org] On Behalf Of 
> Michael S. Tsirkin
> Sent: Tuesday, January 09, 2007 5:57 AM
> To: Steve Wise
> Cc: netdev at vger.kernel.org; Roland Dreier; Divy Le Ray; 
> linux-kernel at vger.kernel.org; openib-general
> Subject: Re: [openib-general] [PATCH 1/10] cxgb3 - main header files
> 
> > We also need to decide on the ib_req_notify_cq() issue.  
> 
> Let's clarify - do you oppose doing copy_from_user from a 
> fixed address passed in during setup?
> 
> If OK with you, this seems the best way as it is the least 
> controversial and least disruptive one.
> 
To clarfiy my understanding of this issue:

A device MAY implement ib_req_notify_cq by updating
a location directly from user mode. Any of the techniques
that apply to other user allocated objects, such as 
the Send Queue, can be applied here.

Even those the proposed changes would be about as
low impact and benign as possible, the fact that there
are valid solutions without an API changes leans heavily
towards using those solutions.





More information about the general mailing list