[openib-general] [PATCH/RFC] IB/ipoib: add selective tx signaling

Roland Dreier rdreier at cisco.com
Wed Jan 10 07:11:39 PST 2007


I played with this idea too a long time ago, but I don't think this
sort of naive implementation is acceptable.  Having packets that take
a potentially unbounded amount of time before the send is completed
and the skb is freed just causes too many problems -- for example the
ping failures that you noted.

Unless you can come up with a way that makes sure that all skbs are
completed even in low-traffic situations, I don't think this is
mergeable -- it's just too much of a usability nightmare to have a
flag that is essentially "break some workloads in a mysterious way to
make some benchmarks run a little faster."

 - R.




More information about the general mailing list